Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): allow for non-js libs to be moved without errors or the creation of any unneeded tsconfig files #28350

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

KerickHowlett
Copy link
Contributor

Current Behavior

I have a project that is utilizing the @nx-go/nx-go extension that's used for supporting Go applications.

When I attempt to use the @nx/workspace:move generator to move a Go library, it'll produce an error. (Please refer to the Failure Logs section for said error.)

Sadly, there isn't a consistent means to get the bun to start showing up, but once it does, the issue will persist throughout the workspace's life cycle.

I was able to trace this to the compiled Javascript files within Nx's installed project files under the node_modules directory, which is where I found a workaround. That being to have the secondaryEntryPointImportPaths variable (located within the updateImports function) set with an empty array on the same line it's declared.

However, this will produce a tsconfig.base.json file at the root of the workspace with the text undefined contained within it and with no actual JSON to speak of.

Expected Behavior

I have a project that is utilizing the @nx-go/nx-go extension that's used for supporting Go applications.

The @nx/workspace:move schematic generator should be able to move libraries based in Go and other programming languages without any errors popping up.

It should also do it without generating an empty tsconfig.base.json file if one didn't exist previously. This tends to be the case when there is no Typescript to speak of within the Nx workspace. For example, an Nx workspace initiated with the @nx-go/nx-go preset.

Related Issue(s)

Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jan 28, 2025 1:49pm

Copy link

nx-cloud bot commented Oct 7, 2024

View your CI Pipeline Execution ↗ for commit 3cd3cb2.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 35m 29s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 1m 8s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base=82c4e... ✅ Succeeded 28s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 27s View ↗
nx documentation --no-dte ✅ Succeeded 50s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-28 14:32:06 UTC

@isaacplmann
Copy link
Collaborator

Don't create a new scope. Use core for changes to workspace. Someone else will review the actual code changes

@KerickHowlett
Copy link
Contributor Author

Don't create a new scope. Use core for changes to workspace. Someone else will review the actual code changes

Oh! That's my bad. I'll undo the commitizen changes and amend my commit messages.

@isaacplmann
Copy link
Collaborator

@jaysoo can you take a look at this PR?

Copy link

nx-cloud bot commented Dec 17, 2024

Your CI Pipeline Execution ↗ for commit f094547 is in progress ⏳

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ❌ Failed 39m 23s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 1m 5s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded <1s View ↗
nx-cloud record -- nx format:check --base=d05f3... ✅ Succeeded 29s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 28s View ↗
nx documentation --no-dte ✅ Succeeded 46s View ↗

☁️ Nx Cloud last updated this comment at 2024-12-18 18:43:13 UTC

@jaysoo jaysoo force-pushed the fix/28349-polyglot-workspace branch from 1020a2a to 3cd3cb2 Compare January 28, 2025 13:46
@jaysoo
Copy link
Member

jaysoo commented Jan 28, 2025

There were fixes from the recent TS solutions changes, just applying small fixes on top of them.

@jaysoo jaysoo merged commit 9a9e6eb into nrwl:master Jan 28, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants