-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): allow for non-js libs to be moved without errors or the creation of any unneeded tsconfig files #28350
fix(core): allow for non-js libs to be moved without errors or the creation of any unneeded tsconfig files #28350
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
View your CI Pipeline Execution ↗ for commit 3cd3cb2.
☁️ Nx Cloud last updated this comment at |
Don't create a new scope. Use |
Oh! That's my bad. I'll undo the commitizen changes and amend my commit messages. |
1458b0b
to
a10cf17
Compare
@jaysoo can you take a look at this PR? |
756614e
to
30903de
Compare
Your CI Pipeline Execution ↗ for commit f094547 is in progress ⏳
☁️ Nx Cloud last updated this comment at |
…eation of any unneeded tsconfig files closed nrwl#28349
1020a2a
to
3cd3cb2
Compare
There were fixes from the recent TS solutions changes, just applying small fixes on top of them. |
Current Behavior
I have a project that is utilizing the
@nx-go/nx-go
extension that's used for supporting Go applications.When I attempt to use the
@nx/workspace:move
generator to move a Go library, it'll produce an error. (Please refer to the Failure Logs section for said error.)Sadly, there isn't a consistent means to get the bun to start showing up, but once it does, the issue will persist throughout the workspace's life cycle.
I was able to trace this to the compiled Javascript files within Nx's installed project files under the
node_modules
directory, which is where I found a workaround. That being to have thesecondaryEntryPointImportPaths
variable (located within theupdateImports
function) set with an empty array on the same line it's declared.However, this will produce a
tsconfig.base.json
file at the root of the workspace with the textundefined
contained within it and with no actual JSON to speak of.Expected Behavior
I have a project that is utilizing the
@nx-go/nx-go
extension that's used for supporting Go applications.The
@nx/workspace:move
schematic generator should be able to move libraries based in Go and other programming languages without any errors popping up.It should also do it without generating an empty
tsconfig.base.json
file if one didn't exist previously. This tends to be the case when there is no Typescript to speak of within the Nx workspace. For example, an Nx workspace initiated with the@nx-go/nx-go
preset.Related Issue(s)